-
-
Notifications
You must be signed in to change notification settings - Fork 29
refactor(speedtest.net): all your servers belong to us #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
revert from cache version, rely solely on button press instead
add lat/long location based server fetching fix correct server id into speedtest-go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should replace all the emojis used with proper icons from lucide/heroicons (or fontawesome if needed). I think all 3 is in the project already.
(I know it's just a draft yet, just something I noticed)
|
I think I got them all. It seems to have improved some redraw issues I was noticing also. The speedtest latency results have an inconsistency that I can't track down. Literally once in a blue moon, and I haven't noticed it recently. The only concern I have with this branch, is my inability to force city name to existing schedules. New schedules push their results as expected. |





This PR extends the speedtest.net server functions, allowing additional speedtest.net servers to be selected. It hooks into the existing speedtest-go application, allowing to fetch all 'city' based servers already defined in that application, and further extends the server selection process by allowing latitude/longitude based server fetching.
By default, existing local servers only functionality remains. Speedtest.net server maintenance is conducted via a new speedtest settings panel. This allows to fetch the speedtest-go 'city' based servers (comprehensive) and input for lat/long server fetching.
Additionally, a further option allows the server city name to be appended to results, to assist with differentiating the same sponsor servers located in different facilities.