Skip to content

Conversation

@afdesk
Copy link
Collaborator

@afdesk afdesk commented Dec 25, 2025

No description provided.

@afdesk afdesk force-pushed the fix/test/pipeline-errors branch from f02d60e to 85f67fc Compare December 25, 2025 07:36
@afdesk afdesk force-pushed the fix/test/pipeline-errors branch from 6f5d0d5 to 94e35b6 Compare December 25, 2025 07:50
@afdesk afdesk changed the title chore: bump up Go to 1.25 ci: bump up Go version in the pipeline Dec 25, 2025
@afdesk afdesk marked this pull request as ready for review December 26, 2025 09:54
@afdesk afdesk requested a review from Copilot December 26, 2025 09:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the CI/CD pipeline's Go version management by transitioning from a hardcoded version in environment variables to reading the version directly from the go.mod file. The changes update both the build and release workflows to use actions/[email protected] with commit SHA pinning for improved security and consistency.

  • Removes hardcoded GO_VERSION environment variable from both workflow files
  • Updates to actions/setup-go@v6 with SHA pinning and uses go-version-file: go.mod parameter
  • Reorders workflow steps to checkout code before setting up Go (required to read go.mod)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Updates the release workflow to use Go version from go.mod and moves Setup Go step after checkout
.github/workflows/build.yml Updates lint, unit tests, e2e tests, and snapshot jobs to use Go version from go.mod with consistent step ordering

Critical Issue Identified: The go.mod file specifies Go version 1.24.11, which does not exist. This will cause all CI workflows to fail as the setup-go action will be unable to find and install this non-existent version. The Go version in go.mod needs to be corrected to a valid version (e.g., 1.23.6 or another valid 1.23.x release).


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant