Skip to content

Conversation

@bbende
Copy link
Contributor

@bbende bbende commented Dec 8, 2025

Summary

NIFI-15243

Improves the KubernetesConfigMapStateProvider....

  1. In setState the original code was calling update with a resource that had no resourceVersion specified and under the covers the k8s client will perform a get in this case to obtain the most recent version before performing the update. Given that, we can call get ourselves every time and simplify the logic to know whether to call create or update, plus simplify the conflict handling logic since we can re-call get on each retry.

  2. In replace we had no way to preserve any changes made to metadata fields, so getState was updated to return the ObjectMetadata from the ConfigMap inside StandardStateMap, then during replace it can use this metadata when constructing the resource to preserve any values.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these improvements @bbende. The general approach reworking update process for ConfigMaps looks good. I noted a few minor recommendations.

@bbende
Copy link
Contributor Author

bbende commented Dec 22, 2025

@exceptionfactory thanks for the review, pushed an update to address the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants