NIFI-15243 Improve KubernetesConfigMapStateProvider #10619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15243
Improves the
KubernetesConfigMapStateProvider....In
setStatethe original code was callingupdatewith a resource that had noresourceVersionspecified and under the covers the k8s client will perform agetin this case to obtain the most recent version before performing the update. Given that, we can callgetourselves every time and simplify the logic to know whether to callcreateorupdate, plus simplify the conflict handling logic since we can re-callgeton each retry.In
replacewe had no way to preserve any changes made to metadata fields, sogetStatewas updated to return theObjectMetadatafrom theConfigMapinsideStandardStateMap, then duringreplaceit can use this metadata when constructing the resource to preserve any values.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation