Skip to content

Conversation

@nagarjunahp88-byte
Copy link

This PR fixes issue #5205 by improving SubscriptionModeConverter.

Changes:

  • Safely handles null and empty values
  • Normalizes input using trim and uppercase
  • Prevents IllegalArgumentException for invalid enum values

This ensures the application does not crash on invalid input.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

@Pil0tXia
Copy link
Member

plz check code style

@nagarjunahp88-byte
Copy link
Author

Thanks for the review!
I’ve updated the code style and added unit tests to cover invalid and null SubscriptionMode values.
Please take another look.

@nagarjunahp88-byte
Copy link
Author

Hi, I’m a new contributor.
I tried joining the ASF Slack via https://s.apache.org/slack-invite
but I’m unable to join since I don’t have an @apache.org email yet.
Could someone please help me with Slack access or guide me to the right channel?
Thanks!

@nagarjunahp88-byte
Copy link
Author

The CI failure seems to be related to Gradle build scan publishing
(develocity.apache.org authentication required), not a compilation
or test failure.

Please let me know if this is expected or if any change is needed
from my side.

@nagarjunahp88-byte nagarjunahp88-byte force-pushed the fix-5205-subscriptionmode-converter branch from 0a5402c to b4e566f Compare December 24, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants