Skip to content

Conversation

@khaled-0
Copy link

This is just "borrowing" the filesize feature from Animiru

@Secozzi
Copy link
Collaborator

Secozzi commented Jan 28, 2025

IMO this feels pretty hacky, especially since it will redo the fetching of filesize everytime you re-enter the entry screen. Wouldn't it be better to store the size information in the database?

@khaled-0
Copy link
Author

IMO this feels pretty hacky, especially since it will redo the fetching of filesize everytime you re-enter the entry screen. Wouldn't it be better to store the size information in the database?

No,
The intended use for this is to quickly guess if the video was downloaded fully or partially
The amount of times I get a downloaded indicator only to see like 20mb video file was very frustrating.
So I added this in Animiru to quickly check and validate if the file is actually downloaded or not.

Also it takes milliseconds to check filesize even for 8+ 2gigs files, And it loads them async way so no ui hang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants