-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feat: Added <select> to control enabling players on Monitor page #4428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR is not needed? |
|
@connortechnology |
|
It is not clear to me why we would want to disable ZMS playback. The .disabled stuff makes sense. |
This PR does NOT disable ZMS playback! At first, I thought about disabling all players, including ZMS, but I later realized that wasn't necessary and locked the code. This PR changes the player selection style. I plan to remove the checkboxes (which are quite confusing if there are more than two players) and switch to multi-select. I think it will be more convenient and look better. |
The code implements support for disabling ALL players, including "ZMS MJPEG", but the UI does not currently use disabling all players. Because at the moment I am not sure that it is necessary to disable all players.
To implement enabling/disabling "ZMS MJPEG" you need to uncomment some lines of code and add a field to the DB
ALTER TABLEMonitorsADD COLUMNZMSEnabledBOOLEAN NOT NULL default true AFTERDecoding``It looks like this: #4393 (comment)
Also added the ability for
<input>to use ".disabled", because if you use the "disabled" attribute for<input>, then the value of<input>will not be used in the form. And now, if you add the "disabled" class, then the value of<input>will be used in the form, but you cannot change its value manually in the UI.If this PR is approved, then in the future you can remove the checkboxes for controlling player enablement from the UI and visually combine the options into the Go2RTC, RTSP2Web & Janus groups
I'm not sure about the feasibility of this PR, but I had some ideas and decided to publish them. Probably, choosing to enable/disable players in one place (in "multi select") is better than many checkboxes.