fix(search-form): enable search input for keyboard accessibility #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 2.1.1 (Keyboard) and WCAG 2.4.3 (Focus Order) violations by making the search input field keyboard accessible while preventing focus trap issues.
Issues Resolved: #23, #77 (duplicates describing the same problem)
Problem: The search input field had a
disabledattribute that blocked keyboard users from accessing core search functionality on the Zanichelli homepage.Solution: Removed the
disabledattribute and implemented proper focus management usingaria-hiddenandtabIndexto prevent focus when the field is visually hidden.Changes
Search Input Field (
search-form.tsx)disabled={!this.showSearchbar}attribute from input elementaria-label="Cerca per parola chiave o ISBN"for screen reader supportaria-hidden={!this.showSearchbar ? 'true' : undefined}to hide from AT when closedtabIndex={!this.showSearchbar ? -1 : 0}to remove from tab order when closedReset Button (consistency improvement)
disabled={!this.showSearchbar}attributearia-hiddenandtabIndexpattern matching input fieldTest Plan
[disabled]attributeEvidence
View before/after screenshots, accessibility trees, and full verification results:
https://app.workback.ai/dashboard/issue/23/
Key Results:
searchbox "Cerca per parola chiave o ISBN" [disabled]searchbox "Cerca per parola chiave o ISBN"(enabled, properly managed){"disabled": false, "focused": true, "canReceiveFocus": true}WCAG References: