Real ESRGAN Support Suwayomi - Updated with fixes #1684
+127
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robonau
reviewed
Sep 29, 2025
server/server-config/src/main/kotlin/suwayomi/tachidesk/server/ServerConfig.kt
Show resolved
Hide resolved
cpiber
reviewed
Sep 29, 2025
Comment on lines
148
to
155
| var currentImage = image | ||
| var currentMimeType = image.second | ||
|
|
||
| // Step 1: Check if HTTP upscaling is configured | ||
| val conversions = serverConfig.downloadConversions.value | ||
| val defaultConversion = conversions["default"] | ||
| val imageType = image.second | ||
| val conversion = conversions[imageType] ?: defaultConversion |
Contributor
There was a problem hiding this comment.
Better than what you had in #1678, but I think it would make sense to allow both upscaling and converting, i.e. first upscale if desired, then convert (as mentioned on discord)
Contributor
There was a problem hiding this comment.
its not really specifically for upscaling, a converter server could also do the conversion to webp or whatever
my use-case for this feature would be just to have access to all the options when converting to webp that the current conversion system hides
Contributor
|
You should create a new branch, not use the master branch to create pull requests (⌐■_■) |
fixed deletions caused by ide
# Conflicts: # server/server-config/src/main/kotlin/suwayomi/tachidesk/server/ServerConfig.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.