Skip to content

Conversation

@DmitryAnansky
Copy link
Contributor

@DmitryAnansky DmitryAnansky commented Dec 17, 2025

What/Why/How?

Fixed the issue of handling of runtime expressions with hyphenated keys in json pointers.

Reference

Closes: #2466

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

🦋 Changeset detected

Latest commit: 0d294d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/respect-core Patch
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint resources/rebilly.yaml 1.461 ± 0.055 1.419 1.612 1.00
redocly-next lint resources/rebilly.yaml 1.475 ± 0.017 1.446 1.504 1.01 ± 0.04

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.58% (🎯 78%) 6185 / 7870
🔵 Statements 78.01% (🎯 78%) 6390 / 8191
🔵 Functions 81.97% (🎯 81%) 1264 / 1542
🔵 Branches 70.39% (🎯 70%) 4239 / 6022
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/respect-core/src/modules/runtime-expressions/replace-json-pointers.ts 100% 100% 100% 100%
Generated in workflow #8195 for commit 0d294d7 by the Vitest Coverage Report Action

@DmitryAnansky DmitryAnansky marked this pull request as ready for review December 17, 2025 14:46
@DmitryAnansky DmitryAnansky requested review from a team as code owners December 17, 2025 14:46
Copy link
Contributor

@vadyvas vadyvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DmitryAnansky DmitryAnansky force-pushed the fix/manage-hyphen-key-names-in-runtime-expressions branch from 6a4c172 to 0d294d7 Compare December 17, 2025 16:32
@DmitryAnansky DmitryAnansky merged commit 19677ee into main Dec 17, 2025
42 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/manage-hyphen-key-names-in-runtime-expressions branch December 17, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect runtime error with hyphen key names in json pointer expression

4 participants