Skip to content

Conversation

@DmitryAnansky
Copy link
Contributor

@DmitryAnansky DmitryAnansky commented Dec 12, 2025

What/Why/How?

Fixed an issue where JSON Pointers containing special characters (like %) were not properly URI-encoded when used as URI identifiers, causing validation errors with properties containing percent signs or other special characters.

Additionally improved performance benchmarking by unifying the pipelines, making the run faster by linting only one API, and adding more versions to compare.

Reference

Related change => #170

Testing

Tested with Redoc/Realm/Reunite => https://github.com/Redocly/redocly/pull/19833

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2025

🦋 Changeset detected

Latest commit: 666c5e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch
@redocly/respect-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DmitryAnansky DmitryAnansky self-assigned this Dec 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.582s ± 0.083s ▓ 1.00x (Fastest)
cli-next 3.834s ± 0.043s ▓▓▓ 1.07x

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.58% (🎯 78%) 6188 / 7874
🔵 Statements 78.01% (🎯 78%) 6393 / 8195
🔵 Functions 81.95% (🎯 81%) 1263 / 1541
🔵 Branches 70.39% (🎯 70%) 4239 / 6022
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/ref-utils.ts 87.5% 96.55% 94.11% 89.65% 9, 49, 71-72
packages/core/src/resolve.ts 96.38% 95.83% 100% 96.22% 84, 276, 425-426, 438-439
packages/core/src/format/codeframes.ts 94.78% 91.13% 100% 96.84% 132, 168, 195, 204, 206, 210
packages/core/src/rules/ajv.ts 89.18% 84.61% 85.71% 97.05% 31, 70, 89
Generated in workflow #8236 for commit 666c5e0 by the Vitest Coverage Report Action

@DmitryAnansky DmitryAnansky added the snapshot Create experimental release PR label Dec 12, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1765541222 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky marked this pull request as ready for review December 12, 2025 12:36
@DmitryAnansky DmitryAnansky requested review from a team as code owners December 12, 2025 12:36
@DmitryAnansky DmitryAnansky added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Dec 12, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1765561541 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

Copy link
Contributor

@kanoru3101 kanoru3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DmitryAnansky DmitryAnansky force-pushed the fix/issue-with-decode-uri-component branch from 54cbc2e to 0452ee1 Compare December 16, 2025 12:20
@DmitryAnansky DmitryAnansky added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Dec 16, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1765888495 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Dec 16, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1765905976 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky force-pushed the fix/issue-with-decode-uri-component branch from cd7edd8 to 92eb22d Compare December 17, 2025 11:11
@DmitryAnansky DmitryAnansky removed the snapshot Create experimental release PR label Dec 17, 2025
@DmitryAnansky DmitryAnansky force-pushed the fix/issue-with-decode-uri-component branch 4 times, most recently from 9d5fb3a to a8d6ab4 Compare December 18, 2025 16:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.658s ± 0.060s ▓ 1.00x
cli-next 3.648s ± 0.030s ▓ 1.00x (Fastest)

@DmitryAnansky DmitryAnansky force-pushed the fix/issue-with-decode-uri-component branch from c10a705 to dda67fe Compare December 22, 2025 12:45
@DmitryAnansky DmitryAnansky force-pushed the fix/issue-with-decode-uri-component branch from ba942f5 to 18dac92 Compare December 23, 2025 10:38
@DmitryAnansky DmitryAnansky force-pushed the fix/issue-with-decode-uri-component branch from 2b6f9bd to 7447189 Compare December 23, 2025 14:39
@DmitryAnansky DmitryAnansky added the snapshot Create experimental release PR label Dec 23, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1766501159 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Dec 23, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1766508919 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Dec 23, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1766518457 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky merged commit 278b929 into main Dec 24, 2025
48 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/issue-with-decode-uri-component branch December 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot Create experimental release PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants