-
Notifications
You must be signed in to change notification settings - Fork 194
fix: allowAdditionalProperties option in example validation rules #2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d6b6ae1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
| schema, | ||
| ctx.location.child('example'), | ||
| ctx, | ||
| !!opts.allowAdditionalProperties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue only partially. If the configuration of the rules is different, there will be a mismatch since the first rule that runs instantiates the AJV instance with its config and ignores the others.
What/Why/How?
Align example validation with the
allowAdditionalPropertiesoption across example-related rules.Previously:
validateExamplefor a single example always passedallowAdditionalProperties: true.no-invalid-parameter-examplesusedallowAdditionalProperties: truefor multi examples, but respectedopts.allowAdditionalPropertiesonly for single examples.Reference
no-invalid-media-type-examplesnot triggering warning for unevaluated properties #2410Testing
Check yourself
Security