-
Notifications
You must be signed in to change notification settings - Fork 194
chore: restrict bundling with --output but without inline apis #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+187
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 164ed15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Contributor
Coverage report
Test suite run success814 tests passing in 121 suites. Report generated by 🧪jest coverage report action from 164ed15 |
JLekawa
reviewed
Nov 12, 2024
JLekawa
reviewed
Nov 12, 2024
JLekawa
reviewed
Nov 12, 2024
JLekawa
approved these changes
Nov 12, 2024
b4fcc07 to
03e6986
Compare
RomanHotsiy
approved these changes
Nov 26, 2024
03e6986 to
164ed15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Trying to clarify the multiple apis bundling behaviour.
Since #1708, we added the
outputoption to theapissection of redocly.yaml.Now when bundling, it doesn't make sense to store files specified in Redocly config under a file/folder specified as a CLI option. Essentially, this change will restrict using
--outputcommand option when there's no inline apis provided in the same command.Reference
Related: #1776
Testing
Screenshots (optional)
Check yourself
Security