AIMIGRAPHX-425 Initial changes getting in max dynamic batch flag into MIGraphX EP #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue where input_shapes could be empty when first loading a model, which would cause model caching to be skipped incorrectly. Key changes: - Fixed incorrect iteration using session_input_names.size() as index into input_tensor vector. Now directly iterates over input_tensor. - Changed loop to include all dimensions (starting from j=0 instead of j=1), as skipping dimension 0 could result in empty shapes for low-rank tensors. - Added validation to check for null shapes and zero dimension sizes before processing. - Added check for has_dim_value() to handle symbolic/dynamic dimensions properly, only including dimensions with concrete positive values. This ensures model caching works correctly when valid input shapes are available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable max dynamic batch size so we can enable dynamic shapes using migarphx's api
Motivation and Context