-
Notifications
You must be signed in to change notification settings - Fork 111
Improve tuning for splitk #4486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes the benchmarking process for GPU kernel tuning (particularly for splitk operations) by improving the compilation and timing of benchmark kernels. The changes add memory optimization passes and adjust timing parameters to get more accurate performance measurements.
Key Changes:
- Added
memory_coloringpass to eliminate redundant memory allocations during benchmarking - Increased benchmark bundle size from 1 to 10 to better amortize kernel launch overhead
- Added
eliminate_identitypass andadd_returncall to properly structure benchmark modules
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Would it possible for you try this PR with ROCm/rocMLIR#2156 in CI ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4486 +/- ##
========================================
Coverage 92.21% 92.21%
========================================
Files 561 561
Lines 27228 27228
========================================
Hits 25108 25108
Misses 2120 2120 🚀 New features to boost your workflow:
|
Motivation
Technical Details
This adds the memory_coloring pass to remove any memory allocations. It also uses a bundle of 10 to get better result due to overhead of multiple kernels.
Changelog Category