fix: check return of probes to ensure Redis is returning responses #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilatomic
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
since we'll be using 2 commands in our script, we want to exit early if the command fails Signed-off-by: Daniel Goldman <[email protected]>
we'll be embedding this in a subcommand invocation, so it's good to have it separated here Signed-off-by: Daniel Goldman <[email protected]>
the redis-cli will return with an exit code of 0 even if the node is loading and not accepting connections (responding with `LOADING Redis is loading the dataset in memory`). `PONG` is returned only when the cluster is ready. Checking for this return ensures that we only count redis nodes as available if they're actually accepting queries. Signed-off-by: Daniel Goldman <[email protected]>
Signed-off-by: Daniel Goldman <[email protected]>
Signed-off-by: Daniel Goldman <[email protected]>
lilatomic
force-pushed
the
issue/1567
branch
from
16d0ff2 to
9cbcd0e
Compare
lilatomic
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
Coverage ? 29.27%
=======================================
Files ? 83
Lines ? 6387
Branches ? 0
=======================================
Hits ? 1870
Misses ? 4318
Partials ? 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Probes check that the response from
pingis "PONG".A
pingcommand has exit code 0 even if the redis instance is loading and not returning responses. This means that a node could be marked as ready even if it was still loading.Fixes #1567
Type of change
Checklist
Additional Context