fix: Correct sidecars format from object to array #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sidecars field in Helm charts was incorrectly configured as object format, but CRD expects array format. This caused Kubernetes API to reject generated CRs, making the feature unusable. Changes: - Convert sidecars from object to array in all chart values.yaml files - Simplify templates to use toYaml directly - Remove unused sidecar.properties helper This is a bug fix as the object format never worked with the CRD. Signed-off-by: drivebyer <[email protected]>
drivebyer
requested review from
iamabhishek-dubey and
shubham-cmyk
as code owners
|
@drivebyer , when does this fix available in production? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidecars field in Helm charts was incorrectly configured as object
format, but CRD expects array format. This caused Kubernetes API to
reject generated CRs, making the feature unusable.
Changes:
This is a bug fix as the object format never worked with the CRD.
Description
Fixes #1600
Type of change
Checklist
Additional Context