Skip to content

Conversation

@drivebyer
Copy link
Collaborator

Description

Fixes #1104

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer marked this pull request as draft October 29, 2024 09:55
@gitguardian
Copy link

gitguardian bot commented Oct 29, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9242444 Triggered Generic Password f712137 tests/e2e-chainsaw/v1beta2/password/redis-standalone/secret.yaml View secret
9242444 Triggered Generic Password f712137 tests/e2e-chainsaw/v1beta2/setup/redis-cluster/secret.yaml View secret
9242444 Triggered Generic Password e3a361f tests/e2e-chainsaw/v1beta2/setup/redis-cluster/secret.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@drivebyer drivebyer changed the title cleanup: remove some duplicated e2e case test: remove some duplicated e2e case Oct 29, 2024
@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.34%. Comparing base (d121d86) to head (7e517c6).
Report is 126 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
+ Coverage   35.20%   44.34%   +9.14%     
==========================================
  Files          19       20       +1     
  Lines        3213     3412     +199     
==========================================
+ Hits         1131     1513     +382     
+ Misses       2015     1813     -202     
- Partials       67       86      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer marked this pull request as ready for review October 30, 2024 09:47
@drivebyer drivebyer marked this pull request as draft October 30, 2024 09:47
drivebyer and others added 6 commits October 30, 2024 18:11
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer marked this pull request as ready for review November 5, 2024 04:46
@drivebyer drivebyer merged commit 9d37c6e into OT-CONTAINER-KIT:master Nov 5, 2024
19 checks passed
@drivebyer drivebyer deleted the e2e-cleanup branch November 5, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: e2e/chainsaw tests are quite flakey

1 participant