-
-
Notifications
You must be signed in to change notification settings - Fork 311
test: remove some duplicated e2e case #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: drivebyer <[email protected]>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9242444 | Triggered | Generic Password | f712137 | tests/e2e-chainsaw/v1beta2/password/redis-standalone/secret.yaml | View secret |
| 9242444 | Triggered | Generic Password | f712137 | tests/e2e-chainsaw/v1beta2/setup/redis-cluster/secret.yaml | View secret |
| 9242444 | Triggered | Generic Password | e3a361f | tests/e2e-chainsaw/v1beta2/setup/redis-cluster/secret.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 35.20% 44.34% +9.14%
==========================================
Files 19 20 +1
Lines 3213 3412 +199
==========================================
+ Hits 1131 1513 +382
+ Misses 2015 1813 -202
- Partials 67 86 +19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Description
Fixes #1104
Type of change
Checklist
Additional Context