Integrate pybind11 stub generation into CMake build #1561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests integrate generating Python stubs for the pyslang bindings into the CMake build process. Previously, the sub generation was done only in the CI which seemed like a brittle way to do it and prevents it from being included if building the package locally (ex. when running
uv build). Also, on our end, the 9.1 release installed from PyPi did not have stubs. Hopefully, this pull request should also fix that issue.Not sure what is the best way to test this. After my changes, I was able to run
uv build, unpack the generated wheel, and manually check the stubs were included. I also installed the wheel into a fresh venv and the stubs are also in there was well. Not sure how to best test the CI integration, but that seems best left up to the maintainers.