Bugfix: Scrolling functionality on short webtoons #3006
Conversation
| } | ||
|
|
||
| if (event.deltaY > 0) { | ||
| this.loadNextChapter.emit(); |
There was a problem hiding this comment.
I didn't update the value of this.scrollingDirection here -- not sure if this is needed. :)
There was a problem hiding this comment.
Yeah, I think it is a good idea so you know the direction you were last scrolling. It wont matter much, but better to have.
|
@Zackareee - I just wanted to reach out and let you know that we've seen the PR's you submitted and aren't ignoring them. The main dev is on vacation right now and will be able to review these as soon as he gets back. Didn't want you to feel discouraged because you haven't gotten a response yet. |
|
Would you be able to DM me a file to test against? |
majora2007
left a comment
majora2007
left a comment
There was a problem hiding this comment.
I do see it working. Scroll doesn't work at all in cases where this is much smaller than the height. I would assume this is expected to work though?
| </div> | ||
|
|
||
| <div *ngIf="atTop" #topSpacer class="spacer top" role="alert" (click)="loadPrevChapter.emit()"> | ||
| <div *ngIf="atTop || heightLessThanView()" #topSpacer [style.height]="heightLessThanView() ? 'inherit' : '300px'" class="spacer top" role="alert" (click)="loadPrevChapter.emit()"> |
There was a problem hiding this comment.
Help me understand the arbitrary 300px? Is this just from the styles? If so, let's make it a css variable and use var(--) on the property so I don't forget to update it in multiple places.
| } | ||
|
|
||
| if (event.deltaY > 0) { | ||
| this.loadNextChapter.emit(); |
There was a problem hiding this comment.
Yeah, I think it is a good idea so you know the direction you were last scrolling. It wont matter much, but better to have.
|
I forgot about this PR, I will note to come back and re-review. |
3 participants
Fixed
When viewing a short webtoon, the previous chapter button is not displayed. Also, scrolling does not go to the next/previous chapter as expected.
To fix, if a webtoon is smaller than the viewport, force the previous chapter button to display. Also, use a separate listener to handle the scroll event.