Skip to content

Conversation

@aslam-quad
Copy link
Contributor

update terraform-provider version to >= 6.9.0, <= 7.14.1

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aslam-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request broadens the supported version range for the Google and Google-Beta Terraform providers. By extending the upper bound of the version constraint, the system can now utilize newer provider releases, ensuring compatibility and access to the latest features and bug fixes, while maintaining a consistent minimum supported version. This change is reflected across the core configuration logic and various golden copy test files.

Highlights

  • Terraform Provider Version Update: The allowed version range for the hashicorp/google and hashicorp/google-beta Terraform providers has been updated to >= 6.9.0, <= 7.14.1.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@aslam-quad aslam-quad added the release-chore To not include into release notes label Dec 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the terraform-provider version for google and google-beta to ">= 6.9.0, <= 7.14.1". The changes are consistently applied across the Go source code, tests, and related golden files. The update is correct and aligns with the PR's objective. I've added a couple of suggestions to improve maintainability by extracting the duplicated version string into a constant in both the implementation and test files. Overall, the changes are good.

Comment on lines 199 to 208
return map[string]TerraformProvider{
"google": {
Source: "hashicorp/google",
Version: ">= 6.9.0, <= 7.12.0",
Version: ">= 6.9.0, <= 7.14.1",
Configuration: gglConf},
"google-beta": {
Source: "hashicorp/google-beta",
Version: ">= 6.9.0, <= 7.12.0",
Version: ">= 6.9.0, <= 7.14.1",
Configuration: gglConf}}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the version string, consider defining it as a constant and reusing it for both google and google-beta providers. This will make future updates easier and less error-prone.

Suggested change
return map[string]TerraformProvider{
"google": {
Source: "hashicorp/google",
Version: ">= 6.9.0, <= 7.12.0",
Version: ">= 6.9.0, <= 7.14.1",
Configuration: gglConf},
"google-beta": {
Source: "hashicorp/google-beta",
Version: ">= 6.9.0, <= 7.12.0",
Version: ">= 6.9.0, <= 7.14.1",
Configuration: gglConf}}
}
const defaultGoogleProviderVersion = ">= 6.9.0, <= 7.14.1"
return map[string]TerraformProvider{
"google": {
Source: "hashicorp/google",
Version: defaultGoogleProviderVersion,
Configuration: gglConf},
"google-beta": {
Source: "hashicorp/google-beta",
Version: defaultGoogleProviderVersion,
Configuration: gglConf}}
}

Comment on lines 93 to +99
c.Check(g.TerraformProviders, DeepEquals, map[string]PR{
"google": TerraformProvider{
Source: "hashicorp/google",
Version: ">= 6.9.0, <= 7.12.0"},
Version: ">= 6.9.0, <= 7.14.1"},
"google-beta": TerraformProvider{
Source: "hashicorp/google-beta",
Version: ">= 6.9.0, <= 7.12.0"}})
Version: ">= 6.9.0, <= 7.14.1"}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the implementation, you can define the version string as a constant here to avoid duplication and improve the maintainability of this test.

		const defaultGoogleProviderVersion = ">= 6.9.0, <= 7.14.1"
		c.Check(g.TerraformProviders, DeepEquals, map[string]PR{
			"google": TerraformProvider{
				Source:  "hashicorp/google",
				Version: defaultGoogleProviderVersion},
			"google-beta": TerraformProvider{
				Source:  "hashicorp/google-beta",
				Version: defaultGoogleProviderVersion}})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant