-
Notifications
You must be signed in to change notification settings - Fork 262
update terraform-provider version to >= 6.9.0, <= 7.14.1 #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
update terraform-provider version to >= 6.9.0, <= 7.14.1 #5034
Conversation
Summary of ChangesHello @aslam-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request broadens the supported version range for the Google and Google-Beta Terraform providers. By extending the upper bound of the version constraint, the system can now utilize newer provider releases, ensuring compatibility and access to the latest features and bug fixes, while maintaining a consistent minimum supported version. This change is reflected across the core configuration logic and various golden copy test files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the terraform-provider version for google and google-beta to ">= 6.9.0, <= 7.14.1". The changes are consistently applied across the Go source code, tests, and related golden files. The update is correct and aligns with the PR's objective. I've added a couple of suggestions to improve maintainability by extracting the duplicated version string into a constant in both the implementation and test files. Overall, the changes are good.
| return map[string]TerraformProvider{ | ||
| "google": { | ||
| Source: "hashicorp/google", | ||
| Version: ">= 6.9.0, <= 7.12.0", | ||
| Version: ">= 6.9.0, <= 7.14.1", | ||
| Configuration: gglConf}, | ||
| "google-beta": { | ||
| Source: "hashicorp/google-beta", | ||
| Version: ">= 6.9.0, <= 7.12.0", | ||
| Version: ">= 6.9.0, <= 7.14.1", | ||
| Configuration: gglConf}} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and avoid duplicating the version string, consider defining it as a constant and reusing it for both google and google-beta providers. This will make future updates easier and less error-prone.
| return map[string]TerraformProvider{ | |
| "google": { | |
| Source: "hashicorp/google", | |
| Version: ">= 6.9.0, <= 7.12.0", | |
| Version: ">= 6.9.0, <= 7.14.1", | |
| Configuration: gglConf}, | |
| "google-beta": { | |
| Source: "hashicorp/google-beta", | |
| Version: ">= 6.9.0, <= 7.12.0", | |
| Version: ">= 6.9.0, <= 7.14.1", | |
| Configuration: gglConf}} | |
| } | |
| const defaultGoogleProviderVersion = ">= 6.9.0, <= 7.14.1" | |
| return map[string]TerraformProvider{ | |
| "google": { | |
| Source: "hashicorp/google", | |
| Version: defaultGoogleProviderVersion, | |
| Configuration: gglConf}, | |
| "google-beta": { | |
| Source: "hashicorp/google-beta", | |
| Version: defaultGoogleProviderVersion, | |
| Configuration: gglConf}} | |
| } |
| c.Check(g.TerraformProviders, DeepEquals, map[string]PR{ | ||
| "google": TerraformProvider{ | ||
| Source: "hashicorp/google", | ||
| Version: ">= 6.9.0, <= 7.12.0"}, | ||
| Version: ">= 6.9.0, <= 7.14.1"}, | ||
| "google-beta": TerraformProvider{ | ||
| Source: "hashicorp/google-beta", | ||
| Version: ">= 6.9.0, <= 7.12.0"}}) | ||
| Version: ">= 6.9.0, <= 7.14.1"}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the implementation, you can define the version string as a constant here to avoid duplication and improve the maintainability of this test.
const defaultGoogleProviderVersion = ">= 6.9.0, <= 7.14.1"
c.Check(g.TerraformProviders, DeepEquals, map[string]PR{
"google": TerraformProvider{
Source: "hashicorp/google",
Version: defaultGoogleProviderVersion},
"google-beta": TerraformProvider{
Source: "hashicorp/google-beta",
Version: defaultGoogleProviderVersion}})
update terraform-provider version to >= 6.9.0, <= 7.14.1
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.