Add vars for managed-lustre settings in slurm blueprints

[parulbajaj01]

Managed-Lustre settings were hardcoded in all slurm blueprints. Introduced vars and made them configurable by the user. Also added relevant documentation links to be referred in order to set the values for these variables.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello @parulbajaj01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the configurability of Managed-Lustre settings within various Slurm blueprints. By externalizing parameters such as instance ID, storage capacity, and throughput into user-definable variables, the change moves away from hardcoded values. This allows for easier customization and adaptation of Managed-Lustre deployments to specific user requirements, streamlining the setup process for high-performance computing environments.

Highlights

• Managed-Lustre Configuration: Replaced hardcoded Managed-Lustre settings in several Slurm blueprints with user-configurable variables, enhancing flexibility and customization.
• Documentation Links: Added relevant documentation links within the blueprint files to guide users on correctly setting the new Managed-Lustre variables.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the Slurm blueprints to use variables for Managed-Lustre settings, replacing hardcoded values. This is a great improvement for maintainability and user configuration. My review includes a couple of minor suggestions to improve comment formatting for consistency and to correct a default value that was changed from its original hardcoded value in one of the blueprints.

[vikramvs-gg]

Let's also add the configurability in pfs-managed-lustre-vm.yaml since this blueprint also uses managed-lustre module.