-
Notifications
You must be signed in to change notification settings - Fork 262
Add integration test for A3 high-GPU with spot VMs #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @simrankaurb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new daily integration test designed to validate the deployment and operational integrity of Slurm clusters provisioned on A3 high-GPU machine types, specifically leveraging cost-effective spot virtual machines. The test ensures that these specialized, GPU-accelerated environments function correctly within the daily test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new integration test for a Slurm cluster on a3-highgpu-8g machine types with spot VMs. The changes look good and introduce necessary configurations for the new test case. I've provided a few suggestions to improve the maintainability and clarity of the new YAML configuration files by removing redundancies and minor inconsistencies. My feedback focuses on using variables for repeated values and cleaning up shell command arguments.
ba263c2 to
53dd687
Compare
This PR adds a new integration test to the daily test suite for validating the deployment and functionality of a Slurm cluster on
a3-highgpu-8gmachine types using spot VMs.This includes:
ml-a3-highgpu-onspot-slurm.yaml) to trigger the test.ml-a3-highgpu-onspot-slurm.yml) that defines the blueprint, variables, and post-deployment validation steps.Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.