Skip to content

Conversation

@okrause
Copy link
Contributor

@okrause okrause commented Dec 3, 2025

This PR adds two blueprints and a README.MD file to a new community/examples/eda folder. It also updates a few README files.

Both blueprints use Google Cloud NetApp Volumes as the shared NFS storage for the compute cluster.

It was developed and reviewed a #4771. This is a replacement PR for the merge.

@okrause okrause requested review from a team and samskillman as code owners December 3, 2025 15:12
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @okrause, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the available reference architectures by introducing two new blueprints tailored for Electronic Design Automation (EDA) workloads on Google Cloud. These additions provide comprehensive solutions for both fully cloud-native and hybrid cloud environments, focusing on optimizing performance and scalability for demanding EDA applications. The core of these solutions relies on Google Cloud NetApp Volumes for shared storage and the Slurm scheduler for compute management, offering flexible deployment options to meet diverse user needs.

Highlights

  • New EDA Blueprints: Introduced two new blueprints for Electronic Design Automation (EDA) workloads: one for all-in-cloud deployments and another for hybrid-cloud scenarios.
  • Google Cloud NetApp Volumes Integration: Both new blueprints leverage Google Cloud NetApp Volumes for high-performance shared NFS storage, crucial for EDA applications.
  • Hybrid Cloud Capabilities: The hybrid-cloud blueprint specifically enables bursting of on-premises EDA workloads to Google Cloud by utilizing NetApp FlexCache for efficient data caching.
  • Slurm Workload Scheduler: The blueprints integrate with the Slurm workload scheduler to manage compute clusters, providing a robust environment for EDA tasks.
  • Documentation Updates: Updated various README files across the repository to reflect the addition of these new EDA blueprints and their features, including a dedicated README for the EDA examples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@okrause
Copy link
Contributor Author

okrause commented Dec 3, 2025

@bytetwin As discussed, here is the new PR with clean git history.
@sarthakag FYI

@okrause okrause mentioned this pull request Dec 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new blueprints for Electronic Design Automation (EDA) workloads, one for all-in-cloud and another for hybrid-cloud scenarios. The changes include the new blueprint YAML files, a comprehensive README for the EDA examples, and updates to existing documentation to include these new examples. The blueprints are well-structured and provide a solid starting point for users. My review includes several suggestions to improve the documentation for clarity and correctness, as well as a high-severity recommendation to refactor a complex and likely incorrect network configuration in both blueprint files to a simpler, standard, and more readable format.

@okrause okrause force-pushed the eda-blueprints-new branch from 663d2ad to c2c3672 Compare December 4, 2025 09:42
@sarthakag
Copy link
Contributor

Hi @okrause,
I see that this branch is out-of-date with the base branch, could you please rebase?

I'm also curious to understand why the previous PR #4771 was closed? Did rebasing not fix the git history? I'm asking so that we don't get into the same issue here or later :)

@bytetwin
Copy link
Collaborator

bytetwin commented Dec 5, 2025

Hi @okrause, I see that this branch is out-of-date with the base branch, could you please rebase?

I'm also curious to understand why the previous PR #4771 was closed? Did rebasing not fix the git history? I'm asking so that we don't get into the same issue here or later :)

I had recommended Oliver to create a new PR because the commit history in the older one was intertwined with other commits probably due to merge instead of a rebase.

@okrause this branch cannot be merged due to it not in line with develop. Please perform teh following

  1. git fetch upstream
  2. git rebase upstream/develop
  3. git push origin eda-blueprints-new --force

bytetwin
bytetwin previously approved these changes Dec 5, 2025
@bytetwin bytetwin added release-chore To not include into release notes release-improvements Added to release notes under the "Improvements" heading. labels Dec 5, 2025
@okrause okrause force-pushed the eda-blueprints-new branch from c2c3672 to 07c4fbe Compare December 5, 2025 09:52
@okrause okrause force-pushed the eda-blueprints-new branch from be17c0b to f9c0ba8 Compare December 9, 2025 19:02
@okrause
Copy link
Contributor Author

okrause commented Dec 9, 2025

Last force push fixed a small link issue in examples/README.md.

@okrause
Copy link
Contributor Author

okrause commented Dec 16, 2025

Rebased to latest develop. Kindly requesting approval @samskillman.

@bytetwin
Copy link
Collaborator

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants