-
Notifications
You must be signed in to change notification settings - Fork 490
chore(deps): update cft/developer-tools docker tag to v1.26 #3317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update cft/developer-tools docker tag to v1.26 #3317
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency update, specifically upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the version of the cft/developer-tools Docker image from 1.25 to 1.26 in cli/Makefile. The change is correct and aligns with the goal of keeping dependencies up-to-date.
However, I noticed that the file infra/cloudbuild/test.devtools.yaml uses a hardcoded and significantly older version of the same Docker image (gcr.io/cloud-foundation-cicd/cft/developer-tools:0.5.0). This inconsistency could lead to tests being run against outdated tooling, potentially missing issues that would appear with the newer version.
While this file is outside the scope of the current changes, I recommend creating a follow-up task to investigate and update this reference for better consistency and maintainability across the repository.
28e1ec9 to
94ec9a2
Compare
|
/gcbrun |
94ec9a2 to
02af84c
Compare
|
/gcbrun |
02af84c to
9e259e7
Compare
|
/gcbrun |
9e259e7 to
070ddd8
Compare
|
/gcbrun |
This PR contains the following updates:
1.25->1.26Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.