Skip to content

Conversation

@davidxuang
Copy link

@davidxuang davidxuang commented Feb 2, 2023

TODOs

  • Check the annotations.
  • Check if the integration works.
  • Determine what scope to use when calling vscode.workspace.getConfiguration.
  • Lua language server does not run in browser. Check if the dependency breaks anything in such environment.

@davidxuang davidxuang force-pushed the master branch 3 times, most recently from 53a41d1 to bdb53d5 Compare February 6, 2023 08:57
@davidxuang davidxuang marked this pull request as ready for review March 11, 2024 15:58
@davidxuang
Copy link
Author

davidxuang commented Mar 11, 2024

  • 浏览器下现在不会触发,但还需要测试引用的依赖会不会直接把宿主炸掉;
  • mw.wikibase 扩展函数比较多,我也不熟悉,有必要也加上注解吗?

@Frederisk
Copy link
Owner

mw.wikibase 扩展函数比较多,我也不熟悉,有必要也加上注解吗?

如果不確定倒是可以先不添加吧,或者等之後另開PR也行?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants