Precompiled shaders #223
Open
Precompiled shaders #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essappSPIRV project
AnastaZIuk
reviewed
Oct 31, 2025
| if (corner.x == 0.0f && corner.y == 0.0f) | ||
| { | ||
| dilationVector.x = ieee754::flipSign(dilationVector.x); | ||
| dilationVector.x = ieee754::flipSign(dilationVector.x, true); |
Member
There was a problem hiding this comment.
you don't have to specify flip arg explicitly, you can cherry pick this one or just change 2 LoCs according to the commit
Comment on lines
+82
to
+84
| #ifdef __HLSL_VERSION | ||
| NBL_REGISTER_OBJ_TYPE(MaterialPacked, 4) | ||
| #endif |
There was a problem hiding this comment.
hmm we could just make NBL_REGISTER_OBJ_TYPE a NOOP for !__HLSL_VERSION
There was a problem hiding this comment.
so we don't have to spam this ifdef everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.