Update Code Challenge #12
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksample89
force-pushed
the
update-challenge
branch
from
ddcf77c to
9b59148
Compare
ksample89
commented
Mar 25, 2022
src/app/containers/Countries/saga.ts
Outdated
| } | ||
| } catch (err) { | ||
| yield put(actions.fetchCountriesError(err.toString())); | ||
| } catch (err: any) { |
Author
There was a problem hiding this comment.
not sure what type this should be
Contributor
There was a problem hiding this comment.
Found this from Mr. Dodds: https://kentcdodds.com/blog/get-a-catch-block-error-message-with-typescript
…nguageswitch, a, link, navbar, formlabel
ksample89
commented
Mar 25, 2022
| 8. Add an error view in case the data fetching has a problem. | ||
|
|
||
| This added container should function roughly like the existing `Countries` container. In the interview, we'll discuss this app, ways to improve it, architectural concepts, best practices and what ideas you think are important in making a strong, reliable and easy to use app. | ||
| 9. Style the page with tailwind. |
Author
There was a problem hiding this comment.
will probably need to leave this off until we add in Tailwind
inlined mock dispatch
ksample89
force-pushed
the
update-challenge
branch
from
53c25a1 to
8c3afc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.