Replace 'visibility_required' with 'modifier_keywords' #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule is deprecated and will be removed in the next major version You should use modifier_keywords instead. https://cs.symfony.com/doc/rules/class_notation/visibility_required.html
FloFrad
approved these changes
Dec 1, 2025
e-zannelli
reviewed
Dec 1, 2025
e-zannelli
left a comment
e-zannelli
left a comment
There was a problem hiding this comment.
Shouldn't we depend on php-cs-fixer ^3.88 then?
Oliboy50
reviewed
Dec 1, 2025
| 'method_argument_space' => ['after_heredoc' => true, 'on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'ignore'], | ||
| 'heredoc_indentation' => true, | ||
| 'visibility_required' => true, | ||
| 'modifier_keywords' => true, |
Member
There was a problem hiding this comment.
will it work using true? 🤔
regarding the docs, it seems to require at least a elements key to be properly configured
There was a problem hiding this comment.
I was understanding true as activate the rule and use the default value (we use it for some other rules) but I cannot find anything to assert that in the documentation
Member
There was a problem hiding this comment.
Gemini says that you're right 👏
Oliboy50
approved these changes
Dec 9, 2025
| 'method_argument_space' => ['after_heredoc' => true, 'on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'ignore'], | ||
| 'heredoc_indentation' => true, | ||
| 'visibility_required' => true, | ||
| 'modifier_keywords' => true, |
Member
There was a problem hiding this comment.
Gemini says that you're right 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule is deprecated and will be removed in the next major version
You should use modifier_keywords instead.
https://cs.symfony.com/doc/rules/class_notation/visibility_required.html