Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025

What this PR does

Adds support for Microsoft.Databricks resources using the stable 2024-05-01 API version.

Closes #4345

Resources Added

  • AccessConnector - Secure data access for Databricks workspaces
  • Workspace - Main Databricks workspace resource
  • WorkspacesPrivateEndpointConnection - Private endpoint management
  • WorkspacesVirtualNetworkPeering - VNet peering configuration

Implementation

Added databricks service configuration to azure-arm.yaml:

databricks:
  2024-05-01:
    AccessConnector:
      $exportAs: AccessConnector
      $supportedFrom: v2.17.0
    Workspace:
      $exportAs: Workspace
      $supportedFrom: v2.17.0
    Workspaces_VirtualNetworkPeering:
      $exportAs: WorkspacesVirtualNetworkPeering
      $supportedFrom: v2.17.0
    VirtualNetworkPeeringPropertiesFormat_RemoteVirtualNetwork:
      Id:
        $referenceType: arm

Configured ARM reference types for VirtualNetworkPeering properties to enable cross-resource references. Removed readonly properties (SystemData from AccessConnector_Spec and CreatedDateTime from WorkspaceProperties) that should only appear in status. Code generator produced 53 files including CRDs, Go types, ARM conversions, storage types, webhooks, and tests.

Usage

apiVersion: databricks.azure.com/v1api20240501
kind: Workspace
metadata:
  name: my-databricks-workspace
spec:
  location: westus2
  owner:
    name: my-resource-group
  managedResourceGroupId: /subscriptions/.../resourceGroups/managed-rg
  sku:
    name: premium

How does this PR make you feel?

gif

Checklist

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples
Original prompt

This section details on the original issue you should resolve

<issue_title>Feature: Add Microsoft.Databricks capabilities</issue_title>
<issue_description>It would be great to be able to manage our Azure Databricks instances via ASO. Here is a link to the ARM template for databricks workspaces.

</issue_description>

Comments on the Issue (you are @copilot in this section)

@theunrepentantgeek New [resource types](https://learn.microsoft.com/en-us/azure/templates/microsoft.databricks/workspaces?pivots=deployment-language-arm-template):
  • Microsoft.Databricks/accessConnectors
  • Microsoft.Databricks/workspaces
  • Microsoft.Databricks/workspaces/privateEndpointConnections
  • Microsoft.Databricks/workspaces/virtualNetworkPeerings</comment_new>
    <comment_new>@theunrepentantgeek
    We're still interested in adding these resources.</comment_new>
    <comment_new>@matthchr
    We're still interested in adding these.</comment_new>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

│ │ ├── ConfigMapExpressions: *core.DestinationExpression[]
│ │ └── SecretExpressions: *core.DestinationExpression[]
│ ├── Owner: *genruntime.KnownResourceReference
│ └── SystemData: *Object (6 properties)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should be readonly. @copilot please prune this SystemData field to the v2/azure-arm.yaml file (see other examples in the file for reference).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed SystemData from AccessConnector_Spec in 1889f01.

│ ├── AzureName: Validated<string> (2 rules)
│ │ ├── Rule 0: MaxLength: 64
│ │ └── Rule 1: MinLength: 3
│ ├── CreatedDateTime: *string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be readonly as well. @copilot please prune this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed CreatedDateTime from WorkspaceProperties in 1889f01.

│ │ └── SecretExpressions: *core.DestinationExpression[]
│ ├── Owner: *genruntime.KnownResourceReference
│ ├── Parameters: *Object (15 properties)
│ │ ├── AmlWorkspaceId: *Object (2 properties)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do something here but I am not sure what.

Copilot AI changed the title [WIP] Add Microsoft.Databricks capabilities for Azure management Add Microsoft.Databricks support Nov 11, 2025
Copilot AI requested a review from matthchr November 11, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Feature: Add Microsoft.Databricks capabilities

2 participants