-
Notifications
You must be signed in to change notification settings - Fork 228
Add Microsoft.Databricks support #5028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: matthchr <[email protected]>
| │ │ ├── ConfigMapExpressions: *core.DestinationExpression[] | ||
| │ │ └── SecretExpressions: *core.DestinationExpression[] | ||
| │ ├── Owner: *genruntime.KnownResourceReference | ||
| │ └── SystemData: *Object (6 properties) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field should be readonly. @copilot please prune this SystemData field to the v2/azure-arm.yaml file (see other examples in the file for reference).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed SystemData from AccessConnector_Spec in 1889f01.
Co-authored-by: matthchr <[email protected]>
| │ ├── AzureName: Validated<string> (2 rules) | ||
| │ │ ├── Rule 0: MaxLength: 64 | ||
| │ │ └── Rule 1: MinLength: 3 | ||
| │ ├── CreatedDateTime: *string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be readonly as well. @copilot please prune this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed CreatedDateTime from WorkspaceProperties in 1889f01.
| │ │ └── SecretExpressions: *core.DestinationExpression[] | ||
| │ ├── Owner: *genruntime.KnownResourceReference | ||
| │ ├── Parameters: *Object (15 properties) | ||
| │ │ ├── AmlWorkspaceId: *Object (2 properties) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do something here but I am not sure what.
… resources Co-authored-by: matthchr <[email protected]>
What this PR does
Adds support for Microsoft.Databricks resources using the stable 2024-05-01 API version.
Closes #4345
Resources Added
AccessConnector- Secure data access for Databricks workspacesWorkspace- Main Databricks workspace resourceWorkspacesPrivateEndpointConnection- Private endpoint managementWorkspacesVirtualNetworkPeering- VNet peering configurationImplementation
Added databricks service configuration to
azure-arm.yaml:Configured ARM reference types for VirtualNetworkPeering properties to enable cross-resource references. Removed readonly properties (
SystemDatafromAccessConnector_SpecandCreatedDateTimefromWorkspaceProperties) that should only appear in status. Code generator produced 53 files including CRDs, Go types, ARM conversions, storage types, webhooks, and tests.Usage
How does this PR make you feel?
Checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.