[trello.com/c/aZtAfZ44] fix select row when we enter the chat via popup #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
requested changes
May 27, 2025
Member
Lainaaa
left a comment
Lainaaa
left a comment
There was a problem hiding this comment.
Could we move updateSelectedRow into the presenter and just on presentChatroom also call updateSelectedRow. We can make it via delegate pattern for example. Because now dev will need to know about your know method and call it when it want to add new functionality for example, lets care about future us and future other devs of this project!
Lainaaa
requested changes
May 28, 2025
Member
Lainaaa
left a comment
Lainaaa
left a comment
There was a problem hiding this comment.
Thanks! The code look to be good!
However, make sure to name your commit! Lets care about our commit history.
So in this case I suggest to squash the commits.
vovameister
force-pushed
the
trello.com/c/aZtAfZ44
branch
from
4bb9933 to
416a4ae
Compare
art-divin
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.