Skip to content

Conversation

@vovameister
Copy link
Member

  1. return scrolling to center using buttons and chat entering besides scroll to "new messages" separator
  2. update hightlight animation, hope I also fix that sometimes its not working or removing to early
  3. add short vibro while highliting
  4. remove reading messages while autoscrolling (scroll to item, not scroll to bottom)
  5. also remove button animation while autoscrolling
  6. put position restore back so it should be earlier to not reproduce chicken animation
  7. return animate = true as it was before for autoscrolling

@vovameister vovameister force-pushed the trello.com/c/iGILackD branch from b1c22cf to 40833e2 Compare April 10, 2025 20:39
@vovameister vovameister requested a review from art-divin April 11, 2025 00:30
@vovameister vovameister changed the title [trello.com/c/iGILackD] many chat update [trello.com/c/iGILackD] many chat updates Apr 11, 2025
Copy link
Member

@Lainaaa Lainaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my comments, I think it becomes more complex and comples, lets make it easier!

@vovameister vovameister requested a review from Lainaaa April 11, 2025 11:16
Copy link
Member

@Lainaaa Lainaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving some of the viewModels variables to the new state

Also, I don't like approach to combine dialog and vibro, instead - use vibro directly if needs

Copy link
Member

@Lainaaa Lainaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider moving state to the viewModel

@vovameister vovameister force-pushed the trello.com/c/iGILackD branch from 1345214 to 818a20e Compare April 11, 2025 13:14
@Lainaaa Lainaaa force-pushed the trello.com/c/iGILackD branch from 818a20e to 3c3a7f2 Compare April 12, 2025 08:17
@Lainaaa Lainaaa self-requested a review April 12, 2025 08:18
@Lainaaa Lainaaa dismissed their stale review April 12, 2025 08:19

Cause it is me

@Lainaaa Lainaaa merged commit 1eaa8b3 into develop Apr 12, 2025
1 check passed
@Lainaaa Lainaaa deleted the trello.com/c/iGILackD branch April 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants