[trello.com/c/2Dz3alvN] Fixed a memory leak. #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PingPongEzZ
force-pushed
the
trello.com/c/2Dz3alvN
branch
from
48aeb79 to
183041f
Compare
PingPongEzZ
changed the title
art-divin
approved these changes
Apr 9, 2025
Collaborator
art-divin
left a comment
art-divin
left a comment
There was a problem hiding this comment.
Consider using copilot or cursor AI to generate tests for these conditions. Can be a part of a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to override HealthCheckWrapped because now we have an option to cancel the tasks
and there is some situations when we are waiting for a connection on the node and recursively calling
requestfunction without any break condition and that is bad and unsafe. I've added a functionality of pushing the associated with the task
UUIDand checking it for a cancellation before doing something in the recursive function
request(waitsForConnectivity:taskId:isCancelled:_ request:)