Skip to content

Commit ef2593c

Browse files
committed
Make container compatible with Nextflow and Singularity
- Add bash to container as Nextflow needs this to do its own business - Replace forced ENTRYPOINT with soft CMD for Singularity and Nextflow + Note: running the container now needs 'hamronize' as first argument, this was previously the implicit (and enforced) ENTRYPOINT - Document in README the docker run ... invocation line - Remove the (unneeded) licensed Conda 'default' channel in README
1 parent 2fa7b12 commit ef2593c

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

Dockerfile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@ LABEL tags="Genomics"
1515
# maintainer
1616
MAINTAINER Finlay Maguire <[email protected]>
1717

18+
# add bash so Nextflow can run the container
19+
RUN apk add --no-cache bash && rm -rf /var/cache/apk/*
20+
1821
# set the working directory in the container
1922
WORKDIR /hAMRonization
2023

2124
# copy the sources into the container
2225
COPY . /hAMRonization/src
2326

2427
# install dependencies and clean all up
25-
RUN python -m pip --no-cache install ./src && rm -rf ./src
28+
RUN python -m pip --no-cache-dir install ./src && rm -rf ./src
2629

27-
# command to run on container start
28-
ENTRYPOINT ["hamronize"]
29-
CMD ["--help"]
30+
# command to run on container start without args
31+
CMD ["hamronize", "--help"]

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ This supports a variety of summary options including an [interactive summary](ht
1919

2020
## Installation
2121

22-
This tool requires python>=3.7 and [pandas](https://pandas.pydata.org/)
22+
This tool requires python>=3.9 and [pandas](https://pandas.pydata.org/)
2323
and the latest release can be installed directly from pip, conda, docker, this repository, or from the galaxy toolshed:
2424
```
2525
pip install hAMRonization
@@ -30,16 +30,17 @@ pip install hAMRonization
3030
Or
3131

3232
```
33-
conda create --name hamronization --channel conda-forge --channel bioconda --channel defaults hamronization
33+
conda create --name hamronization --channel conda-forge --channel bioconda hamronization
3434
```
3535
![version-on-conda](https://anaconda.org/bioconda/hamronization/badges/version.svg)
3636
![conda-download](https://anaconda.org/bioconda/hamronization/badges/downloads.svg)
3737
![last-update-on-conda](https://anaconda.org/bioconda/hamronization/badges/latest_release_date.svg)
3838

3939

40-
Or to install using docker:
40+
Or to install and run using docker, podman, singularity:
4141
```
42-
docker pull finlaymaguire/hamronization:latest
42+
docker pull docker.io/finlaymaguire/hamronization:latest
43+
docker run --rm docker.io/finlaymaguire/hamronization:latest hamronize --help
4344
```
4445

4546
Or to install the latest development version:

0 commit comments

Comments
 (0)