finalize_snippet shouldn't be a global keymap

[IndianBoy42]

It should be set just for the duration of making a snippet and local to the current buffer

maybe in setup the user provides a key (default to <CR>) and the plugin sets it local to the buffer

[ziontee113]

Thank you, @IndianBoy42 for opening the issue.

I currently don't have a good solution to make finalize_snippet not a global keymap. However, I appreciate your input and welcome any pull requests that you or other contributors may have for this issue.

Best regards.

[IndianBoy42]

It would be somewhat of a change in paradigm/ui but if instead of operating within the existing buffer you made a little popup with the selected text when we first invoke the keymap, then you could add buffer local keymaps for all kinds of stuff in there. Like supporting other kinds of nodes other than just insert. Could also show a preview of the output Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Trí Thiện Nguyễn ***@***.***> Sent: Sunday, February 26, 2023 1:52:42 AM To: ziontee113/SnippetGenie ***@***.***> Cc: Anshuman MEDHI ***@***.***>; Mention ***@***.***> Subject: Re: [ziontee113/SnippetGenie] finalize_snippet shouldn't be a global keymap (Issue #2) Thank you, @IndianBoy42<https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIndianBoy42&data=05%7C01%7Camedhi%40connect.ust.hk%7C2da770ad7c6f4702451f08db175919a5%7C6c1d415239d044ca88d9b8d6ddca0708%7C1%7C0%7C638129443671106251%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=a9GKxghMGkv6wbyh5kEY2WRIaDuslU6WOHHr5YWLq20%3D&reserved=0> for opening the issue. I currently don't have a good solution to make finalize_snippet not a global keymap. However, I appreciate your input and welcome any pull requests that you or other contributors may have for this issue. Best regards. — Reply to this email directly, view it on GitHub<https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fziontee113%2FSnippetGenie%2Fissues%2F2%23issuecomment-1445168982&data=05%7C01%7Camedhi%40connect.ust.hk%7C2da770ad7c6f4702451f08db175919a5%7C6c1d415239d044ca88d9b8d6ddca0708%7C1%7C0%7C638129443671106251%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mlR06cGbPV0IFch8umjLBdvDrgOZ%2FgIcScxtxKvLbc4%3D&reserved=0>, or unsubscribe<https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNUNQOYVBQQZRWFTAAQ2H3WZJBGVANCNFSM6AAAAAAVHZN7RQ&data=05%7C01%7Camedhi%40connect.ust.hk%7C2da770ad7c6f4702451f08db175919a5%7C6c1d415239d044ca88d9b8d6ddca0708%7C1%7C0%7C638129443671106251%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FlR5o5gNdgl2v%2BBEojhaSvHsB13d%2B71r58I8HN8Q88Y%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>