Issue #277 - Fix implementation of RECNO/NUMBER keyword

Author: yoavnir

README.md

@@ -10,6 +10,13 @@ This version is liberally based on the [**CMS Pipelines User's Guide and Referen
 
 News
 ====
+03-Jan-2025: Version 0.9.5-HF1 is here
+What's new:
+ * Fixes a bug where `RECNO` within a loop returned the number of iterations of the loop rather than the numbers of records read.
+
+NOTE: This is a non-backwards-compatible change. 
+
+
 29-Dec-2024: Version 0.9.5 is here
 What's New:
 * The `exact()` function prototype for compatibility.
@@ -22,13 +29,6 @@ What's New:
 * A new `--progress` command-line switch to allow the user to monitor progress in reading records.
 * Bug fixes
 
-10-May-2024: Version 0.9.2 is here
-What's New:
-* An unthreaded mode of operation
-* Compound `SET` statements
-* Reduced necessity of quoting complex conditions for `if` and `while`
-* Bug fixes
-
 
 Sources
 =======
@@ -40,7 +40,7 @@ Building
 ========
 If you have downloaded a git repository, first make sure to check out a stable tag such as v0.9.5:
 ```
-git checkout v0.9.5
+git checkout dev-0.9.5-hf1
 ```
 A simple way to get the latest stable release is to check out the `stable` branch and rebase to its tip:
 ```

manpage

@@ -1,7 +1,7 @@
 .\" Manpage for specs.
 .\" Open an issue at https://github.com/yoavnir/specs2016 to correct errors or typos
 .mso www.tmac
-.TH man 1 "1 Jan 2025" "0.9.5" "specs man page"
+.TH man 1 "1 Jan 2025" "0.9.5-HF1" "specs man page"
 .SH NAME
 specs \- a text processing tool
 .SH SYNOPSIS

specs/src/specitems/InputPart.cc

@@ -142,7 +142,7 @@ std::string NumberPart::Debug()
 
 PSpecString NumberPart::getStr(ProcessingState& pState)
 {
-	std::string s = std::to_string(++m_Num);
+	std::string s = std::to_string(pState.getRecordCount());
 	s = std::string(NUMBER_PART_FIELD_LEN - s.length(), ' ') + s;
 	return std::make_shared<std::string>(s);
 }

specs/src/test/ProcessingTest.cc

@@ -741,6 +741,11 @@ int main(int argc, char** argv)
     spec = "SUBSTR WS / WORD 3 of FS i FIELD 2";
 	VERIFY2(spec, "The Epic: 1/Jan/1970 at midnight", "1970 at m"); // Test #186
 
+	// RECNO - Issue #277
+	spec = "WORD 1 a: IF a%2==0 THEN RECNO 1";
+	VERIFY2(spec, "1\n2\n3\n4\n5", "         2\n         4"); // Test #187
+
+
 	if (errorCount) {
 		std::cout << '\n' << errorCount << '/' << testCount << " tests failed.\n";
 		std::cout << "Failed tests: ";

specs/tests/valgrind_unit_tests.py

@@ -1,7 +1,7 @@
 import sys, memcheck, argparse
 
 count_ALU_tests = 749
-count_processing_tests = 186
+count_processing_tests = 187
 count_token_tests = 17
 
 # Parse the one command line options