Skip to content

Commit 900f2f6

Browse files
Copilotsamdark
andcommitted
Address review feedback: fix formatting and update attribution
Co-authored-by: samdark <[email protected]>
1 parent 49016e6 commit 900f2f6

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
- Chg #225: Rename classes: `All` to `AndX`, `Any` to `OrX`. Remove `Group` class (@vjik)
5959
- Chg #226: Refactor filter classes to use readonly properties instead of getters (@vjik)
6060
- New #213: Add `nextPage()` and `previousPage()` methods to `PaginatorInterface` (@samdark)
61-
- New #200: Add `LikeMode` enum and `mode` parameter to `Like` filter for starts with, ends with, and contains matching modes (@copilot)
61+
- New #200: Add `LikeMode` enum and `mode` parameter to `Like` filter for starts with, ends with, and contains matching modes (@samdark)
6262

6363
## 1.0.1 January 25, 2023
6464

tests/Common/Reader/ReaderWithFilter/BaseReaderWithLikeTestCase.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ public function testWithReaderAndMode(
6565
): void {
6666
$reader = $this->getReader()->withFilter(new Like($field, $value, $caseSensitive, $mode));
6767
$actualData = $reader->read();
68-
6968
// Assert that we get the expected fixtures based on the filter criteria
7069
$this->assertFixtures($expectedFixtureIndexes, $actualData);
7170
}

tests/Reader/Iterable/FilterHandler/LikeHandlerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public static function matchWithModeDataProvider(): array
6060
[true, ['id' => 1, 'value' => 'Great Cat Fighter'], 'value', 'Great', null, LikeMode::CONTAINS],
6161
[true, ['id' => 1, 'value' => 'Great Cat Fighter'], 'value', 'Fighter', null, LikeMode::CONTAINS],
6262

63-
// STARTS_WITH mode tests
63+
// STARTS_WITH mode
6464
[true, ['id' => 1, 'value' => 'Great Cat Fighter'], 'value', 'Great', null, LikeMode::STARTS_WITH],
6565
[true, ['id' => 1, 'value' => 'Great Cat Fighter'], 'value', 'great', false, LikeMode::STARTS_WITH],
6666
[false, ['id' => 1, 'value' => 'Great Cat Fighter'], 'value', 'great', true, LikeMode::STARTS_WITH],

0 commit comments

Comments
 (0)