Skip to content

Commit 76559a8

Browse files
committed
Add more tests and change constraints php
1 parent affaa3c commit 76559a8

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"prefer-stable": true,
3333
"minimum-stability": "dev",
3434
"require": {
35-
"php": "^8.1",
35+
"php": "8.1 - 8.4",
3636
"ext-mbstring": "*",
3737
"cycle/database": "^2.11",
3838
"cycle/orm": "^2.9",

tests/Feature/Base/Reader/BaseEntityReaderTestCase.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,12 @@ public function testLimitException(): void
131131
(new EntityReader($this->select('user')))->withLimit(-1);
132132
}
133133

134+
public function testGetLimit(): void
135+
{
136+
$reader = (new EntityReader($this->select('user')))->withLimit(2);
137+
$this->assertSame(2, $reader->getLimit());
138+
}
139+
134140
public function testLimitOffset(): void
135141
{
136142
$reader = (new EntityReader(
@@ -140,6 +146,12 @@ public function testLimitOffset(): void
140146
$this->assertFixtures([1, 2], $reader->read());
141147
}
142148

149+
public function testGetOffset(): void
150+
{
151+
$reader = (new EntityReader($this->select('user')))->withOffset(1);
152+
$this->assertSame(1, $reader->getOffset());
153+
}
154+
143155
public function testFilter(): void
144156
{
145157
$reader = (new EntityReader($this->select('user')))->withFilter(new Equals('number', 2));
@@ -159,6 +171,13 @@ public function testFilterHandlers(): void
159171
$reader->read();
160172
}
161173

174+
public function testGetFilter(): void
175+
{
176+
$filter = new Equals('number', 2);
177+
$reader = (new EntityReader($this->select('user')))->withFilter($filter);
178+
$this->assertSame($filter, $reader->getFilter());
179+
}
180+
162181
public static function dataGetSql(): array
163182
{
164183
return [

0 commit comments

Comments
 (0)