Skip to content

Support for Unicode 16 (two test failures) #1790

@DonKult

Description

@DonKult

Hi,

running update_unicode.py against Unicode 16 results in files that work just fine (for me at least), but the changes since 15 seem to break two assumptions in the tests: The two tested characters are now in the indic extend set it seems.

With the following patch all tests pass again, but my knowledge of Unicode is limited and so the effect this change has.

--- a/cpp/ycm/tests/CodePoint_test.cpp
+++ b/cpp/ycm/tests/CodePoint_test.cpp
@@ -87,12 +87,16 @@
                 GraphemeBreakProperty::EXTEND,
                 IndicConjunctBreakProperty::EXTEND } },
   // Bengali vowel sign Aa
-  { "া", { "া", "া", "া", false, false, false, GraphemeBreakProperty::EXTEND } },
+  { "া", { "া", "া", "া", false, false, false,
+                GraphemeBreakProperty::EXTEND,
+                IndicConjunctBreakProperty::EXTEND } },
   // Zero-width non-joiner
   { "", { "", "", "", false, false, false,
                 GraphemeBreakProperty::EXTEND } },
   // Combining cyrillic millions sign
-  { "", { "", "", "", false, false, false, GraphemeBreakProperty::EXTEND } },
+  { "", { "", "", "", false, false, false,
+                GraphemeBreakProperty::EXTEND,
+                IndicConjunctBreakProperty::EXTEND } },

   // Zero-width joiner
   { "", { "", "", "", false, false, false,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions