Commit 6b6084a
committed
MESSAGE_POLL_TIMEOUT should be enough for extra conf and StartServer() to complete
This is a UT fixup for a change in _AwaitServerMessages.
Note that #1434 (comment) is not exactly correct together with #1434.
Quote:
> (...) Note that the java completer has a ton of setup to do before it gets to the super().StartServer().
It's true that it has some additional tasks (wiping out workspace) before it calls *super()._StartServerNoLock()*. But
PR 1434 doesn't address it - wiping workspace is called from JavaCompleter.StartServer() at which point _server_started
is already True, so the following part from that PR in _AwaitServerMessages():
-return self._initialize_event.is_set()
+return not self._server_started or self._initialize_event.is_set()
did not make it return True. In other words, #1434 seems to not address the JavaCompleter issue, but only the issue with
potentially long extra conf Settings(). However according to
#1433 (comment) this should rather be solved by increasing
MESSAGE_POLL_TIMEOUT. Anyway, one of the first things we do from OnFileReadyToParse() when server is not healthy is
setting _server_started to True.1 parent 89ed4cf commit 6b6084a
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1482 | 1482 | | |
1483 | 1483 | | |
1484 | 1484 | | |
1485 | | - | |
| 1485 | + | |
1486 | 1486 | | |
1487 | 1487 | | |
1488 | 1488 | | |
1489 | | - | |
| 1489 | + | |
1490 | 1490 | | |
1491 | 1491 | | |
1492 | 1492 | | |
| |||
0 commit comments