chore: some code smells

Signed-off-by: iGxnon <[email protected]>

Author: iGxnon

jxline-core/src/main/java/cloud/xline/jxline/impl/ProtocolClientImpl.java

@@ -252,6 +252,10 @@ int recoverQuorum(int size) {
         return quorum(size) / 2 + 1;
     }
 
+    static final int RETRY_TIMEOUT = 3;
+    static final int RETRY_LIMIT = 5;
+
+    // TODO: Need to be refactored within retry policy...
     State getInitState() {
         ManagedChannel initChannel = this.connectionManager().getInitChannel();
         VertxProtocolGrpc.ProtocolVertxStub initStub = VertxProtocolGrpc.newVertxStub(initChannel);
@@ -261,11 +265,13 @@ State getInitState() {
         int retries = -1;
         do {
             retries++;
-            if (retries > 5) {
+            if (retries > RETRY_LIMIT) {
                 throw new RuntimeException("connection failed");
             }
             try {
-                response = completable(initStub.fetchCluster(request)).get(3, TimeUnit.SECONDS);
+                response =
+                        completable(initStub.fetchCluster(request))
+                                .get(RETRY_TIMEOUT, TimeUnit.SECONDS);
             } catch (Exception e) {
                 logger().warn("fetch cluster failed, " + e);
             }

jxline-core/src/test/java/ProtocolTest.java

@@ -5,15 +5,18 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
+
 import static org.assertj.core.api.Assertions.*;
 
 @Timeout(value = 20)
 public class ProtocolTest {
     static ProtocolClient client;
 
+    static String INIT_ENDPOINT = "http://172.20.0.5:2379";
+
     @BeforeAll
     static void onConnect() {
-        client = Client.builder().endpoints("http://172.20.0.5:2379").build().getProtocolClient();
+        client = Client.builder().endpoints(INIT_ENDPOINT).build().getProtocolClient();
     }
 
     @Test