From 7c8e4b7bec154d45ca4145f8ea53b24d68dfa0bf Mon Sep 17 00:00:00 2001 From: Ruben Pingol <128448242+rubenberttpingol@users.noreply.github.com> Date: Thu, 15 Jan 2026 22:30:32 +0800 Subject: [PATCH] Fix poc mvp linux packaging (#19) * Update player name to xibo-player * Update release gh action for snap packaging * Revert pack snap action and explicitly define relative path for snapcraft config source * Fix path of github action task for building windows package * Fixing linux build gha workflow --- .github/workflows/release.yml | 17 ++++++++--------- snap/snapcraft.yaml | 2 +- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index eab5dc5..0226bed 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -27,18 +27,15 @@ jobs: - name: 'Install Dependencies' run: npm ci - - name: 'Build Application Packages' + - name: 'Build .deb (Electron Forge)' run: npm run make env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: 'Pack Snap' - id: snap-build - run: | - # --destructive-mode allows building without a VM/Container - sudo snapcraft pack --destructive-mode - # Set the snap path as an output for the next steps - echo "SNAP_PATH=$(ls *.snap | head -n 1)" >> $GITHUB_ENV + - name: 'Build .snap (Snapcraft)' + run: npm run make:snap + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: 'Upload .deb to Release' run: | @@ -53,8 +50,10 @@ jobs: env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: 'Publish to Snap Store' + - name: 'Upload .snap to Snap Store' uses: snapcore/action-publish@v1 + run: | + echo "SNAP_PATH=$(find ./out/make/snap -name "*.snap" -type f | head -n 1)" >> $GITHUB_ENV with: store_login: ${{ secrets.SNAPCRAFT_LOGIN }} file: ${{ env.SNAP_PATH }} diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml index b0c5b0d..ec7cb65 100644 --- a/snap/snapcraft.yaml +++ b/snap/snapcraft.yaml @@ -26,7 +26,7 @@ apps: parts: app: plugin: dump - source: ./out/xibo-electron-linux-x64 + source: out/xibo-electron-linux-x64 source-type: local stage-packages: - libglib2.0-0