CMM-1121 enable application password for all sites linking (#22466)

* Removing the check when adding a new site

* Cleaning LoginSiteAddressFragment

* Checkstyle

Author: adalpari

WordPress/src/androidTest/java/org/wordpress/android/e2e/flows/LoginFlow.kt

@@ -127,7 +127,7 @@ class LoginFlow {
 
     fun enterSiteAddress(siteAddress: String?): LoginFlow {
         // Site Address Screen – Fill it in and click "Continue"
-        // See LoginSiteAddressFragment
+        // See LoginSiteApplicationPasswordFragment
         WPSupportUtils.populateTextField(R.id.input, siteAddress)
         WPSupportUtils.clickOn(R.id.bottom_button)
         return this

WordPress/src/main/java/org/wordpress/android/ui/accounts/LoginActivity.java

@@ -40,7 +40,6 @@
 import org.wordpress.android.login.LoginMagicLinkRequestFragment;
 import org.wordpress.android.login.LoginMagicLinkSentFragment;
 import org.wordpress.android.login.LoginMode;
-import org.wordpress.android.login.LoginSiteAddressFragment;
 import org.wordpress.android.ui.accounts.login.applicationpassword.LoginSiteApplicationPasswordFragment;
 import org.wordpress.android.login.LoginUsernamePasswordFragment;
 import org.wordpress.android.login.SignupConfirmationFragment;
@@ -72,7 +71,6 @@
 import org.wordpress.android.ui.posts.BasicFragmentDialog.BasicDialogPositiveClickInterface;
 import org.wordpress.android.ui.prefs.AppPrefs;
 import org.wordpress.android.ui.prefs.experimentalfeatures.ExperimentalFeatures;
-import org.wordpress.android.ui.prefs.experimentalfeatures.ExperimentalFeatures.Feature;
 import org.wordpress.android.ui.reader.services.update.ReaderUpdateLogic;
 import org.wordpress.android.ui.reader.services.update.ReaderUpdateServiceStarter;
 import org.wordpress.android.util.AppLog;
@@ -202,11 +200,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
                 case JETPACK_SELFHOSTED:
                 case SELFHOSTED_ONLY:
                     mUnifiedLoginTracker.setSource(Source.SELF_HOSTED);
-                    if (mExperimentalFeatures.isEnabled(Feature.EXPERIMENTAL_APPLICATION_PASSWORD_FEATURE)) {
-                        showFragment(new LoginSiteApplicationPasswordFragment(), LoginSiteAddressFragment.TAG);
-                    } else {
-                        showFragment(new LoginSiteAddressFragment(), LoginSiteAddressFragment.TAG);
-                    }
+                    showFragment(new LoginSiteApplicationPasswordFragment(), LoginSiteApplicationPasswordFragment.TAG);
                     break;
                 case JETPACK_STATS:
                     mUnifiedLoginTracker.setSource(Source.JETPACK);
@@ -579,13 +573,7 @@ public void gotUnregisteredSocialAccount(String email, String displayName, Strin
 
     @Override
     public void loginViaSiteAddress() {
-        final Fragment loginSiteAddressFragment;
-        if (mExperimentalFeatures.isEnabled(Feature.EXPERIMENTAL_APPLICATION_PASSWORD_FEATURE)) {
-            loginSiteAddressFragment = new LoginSiteApplicationPasswordFragment();
-        } else {
-            loginSiteAddressFragment = new LoginSiteAddressFragment();
-        }
-        slideInFragment(loginSiteAddressFragment, true, LoginSiteAddressFragment.TAG);
+        slideInFragment(new LoginSiteApplicationPasswordFragment(), true, LoginSiteApplicationPasswordFragment.TAG);
     }
 
     @Override