chore: attend pr review comments

Author: guidiaz

src/bin/cli/priceFeeds.cjs

@@ -14,7 +14,7 @@ module.exports = async (options = {}, args = []) => {
 	helpers.traceHeader(`${network.toUpperCase()}`, helpers.colors.lcyan);
 	const framework = await helpers.prompter(utils.fetchWitOracleFramework(provider));
 
-	let { target } = options
+	let { target } = options;
 	let chosen = false;
 	if (!target) {
 		const artifacts = Object.entries(framework).filter(([key]) => key.startsWith("WitPriceFeeds"));

src/lib/wrappers/WitOracle.ts

@@ -267,7 +267,7 @@ export class WitOracle extends WitArtifact {
 
 	/**
 	 * Wrapper class for Wit/Oracle Radon Template artifacts as deployed in some supported EVM network.
-	 * `IWitOracleRadonRequestTemplate` contracts enable smart contracts to formally verify Radon Requests
+	 * `IWitOracleRadonRequestTemplateFactory` contracts enable smart contracts to formally verify Radon Requests
 	 * built out out of a set of parameterized Witnet-compliant data sources, on the fly.
 	 */
 	public async getWitOracleRadonRequestTemplateFactoryAt(

src/lib/wrappers/WitPriceFeeds.ts

@@ -11,7 +11,7 @@ import {
 	type PriceFeedInfo,
 	PriceFeedMappers,
 	PriceFeedOracles,
-	PriceFeedQoS,
+	type PriceFeedQoS,
 	type PriceFeedUpdate,
 	type PriceFeedUpdateConditions,
 } from "../types.js";
@@ -460,13 +460,13 @@ export class WitPriceFeeds extends WitAppliance {
 	}
 
 	public async lookupPriceFeedID(id4: Witnet.HexString): Promise<Witnet.Hash> {
-		return this.contract.lookupPriceFeedID.staticCall(id4);
+		return this.contract.lookupPriceFeedID32.staticCall(id4);
 	}
 
 	public async lookupPriceFeedQualityMetrics(id4: Witnet.HexString): Promise<PriceFeedQoS> {
 		return this.contract.lookupPriceFeedQualityMetrics.staticCall(id4).then((result: any) => ({
 			computesEMA: result[0],
-			maxDeviationPercentage: Number(result[1]),
+			maxDeviationPercentage: Number(result[1]) / 10,
 			maxSecsBetweenUpdates: Number(result[2]),
 			minSecsBetweenUpdates: Number(result[3]),
 			numFallbackOracles: Number(result[4]),

test/TestWitOracleRadonEncodingLib.sol

@@ -71,9 +71,9 @@ contract TestWitOracleRadonEncodingLib {
 
   function testEncodeRadonReducer1Filter() external {
     Witnet.RadonReducer memory reducer;
-    reducer.opcode = Witnet.RadonReducerMethods.Mode;
+    reducer.method = Witnet.RadonReducerMethods.Mode;
     reducer.filters = new Witnet.RadonFilter[](1);
-    reducer.filters[0].opcode = Witnet.RadonFilterMethods.StandardDeviation;
+    reducer.filters[0].method = Witnet.RadonFilterMethods.StandardDeviation;
     reducer.filters[0].cborArgs = hex"fa40200000";
     bytes memory bytecode = WitOracleRadonEncodingLib.encode(reducer);
     // emit Log(bytecode);