Skip to content

Mismatched gRPC schema to JSON should not log exceptions #147

@Mahoney

Description

@Mahoney

Proposal

If a stub is configured with JSON that does not conform to the gRPC schema an exception hits the top of the stack and gets logged:

com.google.protobuf.InvalidProtocolBufferException: Cannot find field: name in message HelloReply
	at com.google.protobuf.util.JsonFormat$ParserImpl.mergeMessage(JsonFormat.java:1518)
	at com.google.protobuf.util.JsonFormat$ParserImpl.merge(JsonFormat.java:1478)
	at com.google.protobuf.util.JsonFormat$ParserImpl.merge(JsonFormat.java:1360)
	at com.google.protobuf.util.JsonFormat$Parser.merge(JsonFormat.java:478)
	at org.wiremock.grpc.internal.JsonMessageConverter.lambda$toMessage$1(JsonMessageConverter.java:40)
	at com.github.tomakehurst.wiremock.common.Exceptions.uncheck(Exceptions.java:72)
	at org.wiremock.grpc.internal.JsonMessageConverter.toMessage(JsonMessageConverter.java:40)
	at org.wiremock.grpc.internal.UnaryServerCallHandler.lambda$invoke$0(UnaryServerCallHandler.java:92)
	at com.github.tomakehurst.wiremock.http.AbstractRequestHandler.handle(AbstractRequestHandler.java:102)
	at org.wiremock.grpc.internal.UnaryServerCallHandler.invoke(UnaryServerCallHandler.java:57)
	at org.wiremock.grpc.internal.UnaryServerCallHandler.invoke(UnaryServerCallHandler.java:33)

We should handle this better.

References

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions