Merge pull request #192 from whereby/havard/pan-723-verify-v2-cdn-build-works

Final tweaks before removing the beta tag

Author: havardholvik

.github/workflows/deploy.yml

@@ -60,15 +60,15 @@ jobs:
                   aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
                   aws-region: eu-west-1
 
-            - uses: jakejarvis/s3-sync-action@master
+            - uses: jakejarvis/s3-sync-action@v0.5.1
               with:
                   args: --acl public-read --follow-symlinks
               env:
                   AWS_S3_BUCKET: whereby-cdn
                   AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
                   AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
                   AWS_REGION: "es-west-1"
-                  SOURCE_DIR: "dist/"
+                  SOURCE_DIR: "dist/cdn/"
                   DEST_DIR: "embed/"
 
             - name: Invalidate cloudfront publication

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@whereby.com/browser-sdk",
-    "version": "2.0.0-beta4",
+    "version": "2.0.0",
     "description": "Modules for integration Whereby video in web apps",
     "author": "Whereby AS",
     "license": "MIT",

rollup.config.js

@@ -9,16 +9,21 @@ const { dts } = require("rollup-plugin-dts");
 
 const peerDependencies = [...Object.keys(pkg.peerDependencies || {})];
 
-function makeCdnFilename() {
+function makeCdnFilename(package) {
     const major = pkg.version.split(".")[0];
-    const preRelease = pkg.version.split("-")[1];
-    let tag = "";
 
+    let tag = "";
+    const preRelease = pkg.version.split("-")[1];
     if (preRelease) {
         tag = `-${preRelease.split(".")[0]}`;
     }
 
-    return `v${major}${tag}.js`;
+    let packagePart = "";
+    if (package) {
+        packagePart = `-${package}`;
+    }
+
+    return `v${major}${packagePart}${tag}.js`;
 }
 
 const replaceValues = {
@@ -88,17 +93,19 @@ module.exports = [
         external: ["heresy", ...peerDependencies],
         plugins,
     },
-    // Legacy build of embedded lib in ESM format, bundling the dependencies
+
+    // CDN builds
     {
         input: "src/lib/embed/index.ts",
         output: {
-            exports: "named",
-            file: `dist/${makeCdnFilename()}`,
-            format: "esm",
+            file: `dist/cdn/${makeCdnFilename("embed")}`,
+            format: "iife",
+            name: "whereby",
         },
         plugins: [nodeResolve(), commonjs(), json(), terser(), replace(replaceValues), typescript()],
     },
-    // Roll-up .d.ts definition files
+
+    // Type definitions
     {
         input: "src/lib/react/index.ts",
         output: [{ file: "dist/react/index.d.ts", format: "es" }],