Type error: destructuring from undefined in Authorization.ts

[dan1kov]

Ox Version

0.8.8

Current Behavior

In src/core/Authorization.ts#L270-L276, the code attempts to spread ...signature, where signature can be undefined:

ox/src/core/Authorization.ts

Lines 270 to 276 in 4e9b494

	const signature =
	yParity && r && s ? Signature.fromTuple([yParity, r, s]) : undefined
	return from({
	address,
	chainId: chainId === '0x' ? 0 : Number(chainId),
	nonce: nonce === '0x' ? 0n : BigInt(nonce),
	...signature,

This causes a TypeScript compilation error because object spread cannot destructure undefined.

Expected Behavior

no type errors

[dan1kov]

@jxom, could you please review this issue?

[Pasha8914]

@jxom @tmm I would like to bring this matter to your attention as it is of the utmost importance to me. I would be most grateful for your assistance

[jxom]

Feel free to PR!

[sherpya]

the fatest way is to add ! after signature, or better, before return from({...})

if (!signature) {
    throw Error(); // or whatever
}

[sherpya]

I think this solution is better:

  const signature =
    yParity && r && s ? Signature.fromTuple([yParity, r, s]) : {}

[dan1kov]

The "exactOptionalPropertyTypes": true setting in tsconfig.base.json (line 19) conflicts with the current type design.

Undefined<...> and object spreads produce fields with undefined, but exact-optional semantics require fields to be omitted, leading to unnecessary type errors.

[github-actions]

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Ox version. If you have any questions or comments you can create a new discussion thread.