Static data bundling

[tnspacetime]

Related plugins

• plugin-react

• plugin-react-swc

• plugin-react-oxc

• plugin-rsc

Describe the bug

I don’t fully understand if this is a a bug or expected. I was testing out the ssg example (more precisely, borrowing the ssg code to use in the starter). I saw that while ssg worked, the raw source files (from glob) are bundled into the rsc bundle also, significantly increasing the size in case you have a lot of source files. I attempted to fix it in my case by running two builds. It worked (I checked everything and even deployed on cloudflare), but it seemed a bit hacky. Is the behaviour expected, and do we have a “better fix”?

Reproduction

N/A

Steps to reproduce

Attempt to do ssg and check the rsc bundle. The source files will be included in the bundle.

System Info

bun, vite

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[hi-ogawa]

Can you provide reproduction? Or if it reproduces on ssg example, then can you explain it better which file is expected or not expected etc? Also if relevant, can you explain your workaround?

[github-actions]

Hello @tnspacetime. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

[tnspacetime]

Hi @hi-ogawa , have a look at this repo

https://github.com/tnspacetime/ssg-bundling-test

So the idea is: I have a bunch of txt files (inside src/data) that I want to do static rendering. With normal ssg, these txt files will be contained inside dist/src/index.js. But of course I don't want that, because when deploy the app or running vite preview, static assets inside dist/client are served, so the inclusion of those txt files in the rsc bundle increase the bundle size.

As you can see, my rather hacky solution was to do a two builds (see "build:ssg" inside package.json) and the detail in vite.config.ts where in the second build, I preserve the static assets generated from the first build.

FYI, this is the screenshot for the ssg build where the txt files are included in the bundle:

This is the build where the txt file are excluded:

I think this issue is important because if you have a lot of source files (txt files), the bundle size could get too large.

[hi-ogawa]

Thanks for the example. I understood the situation now, but I don't think this is RSC plugin issue, but it's a general issue with prerender/ssr hybrid with import.meta.glob, which needs to bundle up data as modules. Your "workaround" is very sane to me.

Another approach is to move away from import.meta.glob + raw and use fs.readFile to read file directly during prerendering, so those files aren't baked in as server bundle. I think you can basically replace your modules with something like this.

// const modules = import.meta.glob("./data/*.txt", ...)
const modules = {
  "a.txt": () => fs.readFileSync("./data/a.txt", "utf-8"),
  "b.txt": () => fs.readFileSync("./data/b.txt", "utf-8"),
  ...
}

Closing this since this is not a plugin issue, but it's more about general ssg approach.

[tnspacetime]

Thanks for your comment. I agree this is not a plugin issue. Often use cases that involve pre-rendering do involve touching md/txt files though so I think this is important to be aware of.