Github version 0.4 declare itself as 0.3.8

[mpagot]

$  pwd
/tmp/vale

$ mkdir 0.3.8
$ cd 0.3.8
$  wget https://github.com/errata-ai/vale-ls/releases/download/v0.3.8/vale-ls-x86_64-unknown-linux-gnu.zip
$ cd ..
$ md5sum 0.3.8/vale-ls-x86_64-unknown-linux-gnu.zip
75e89b86a487385fb01fda067f5ea9a4  0.3.8/vale-ls-x86_64-unknown-linux-gnu.zip


$ mkdir 0.4
$ cd 0.4
$  wget https://github.com/errata-ai/vale-ls/releases/download/v0.4.0/vale-ls-x86_64-unknown-linux-gnu.zip
$ cd ..
$ md5sum 0.4/vale-ls-x86_64-unknown-linux-gnu.zip
56381c8c9c52255073315bd077cde884  0.4/vale-ls-x86_64-unknown-linux-gnu.zip


$  cd 0.3.8
$  unzip vale-ls-x86_64-unknown-linux-gnu.zip
$  /tmp/vale/0.3.8/vale-ls --version
0.3.8


$  cd ../0.4
$  unzip vale-ls-x86_64-unknown-linux-gnu.zip
$  /tmp/vale/0.4/vale-ls --version
0.3.8 <-- NOT EXPECTED

Version has not been updated in the Cargo.toml

[moritzfl]

This does not seem to be an isolated problem. I created a homebrew tap and my tests had the following results (mismatch of reported version vs. expected version):

Formula	Expected	Reported
vale-ls@0.1.1	0.1.1	0.1.0
vale-ls@0.2.0	0.2.0	0.1.0
vale-ls@0.3.0	0.3.0	0.1.0
vale-ls@0.3.1	0.3.1	0.1.0
vale-ls@0.3.2	0.3.2	0.1.0
vale-ls@0.3.3	0.3.3	0.1.0
vale-ls@0.3.4	0.3.4	0.1.0
vale-ls@0.3.5	0.3.5	0.1.0
vale-ls@0.4.0	0.4.0	0.3.8

homebrew-tap can be found here: https://github.com/moritzfl/homebrew-vale-ls

Its github action currently only succeeds because I "allowed" failures for the versions listed above (on both linux and macos). This is somewhat unfortunate - perhaps some kind of automated check can be implemented here (in the vale-ls repo) aswell?

Warning: vale-ls@0.3.2 failed but is allowed