-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Right now, RWS is using websocketpp, asio and nlohmann/json and these 3 libraries will be fetched by CMake during configuration step. Is there a reason they need to be built like this? Can the libraries installable via apt work?
You can add the following to the package.xml file
<build_depend>asio</build_depend>
<build_depend>nlohmann-json-dev</build_depend>
<build_depend>libwebsocketpp-dev</build_depend>Then the rosdep tool can be used to install the correct packages from apt. Note that the rosdep tool works for other linux distributions than just Ubuntu.
Maybe you can also change the CMakeLists.txt to attempt to find_package and if it fails to find a package then fetch and build? I also think that automatic fetching and building should be an option that is disabled by default.
Metadata
Metadata
Assignees
Labels
No labels