Skip to content

Commit 46131ed

Browse files
committed
Fixes typo in MockPublicationRepository class name
Adds docblocks to MockPublicationRepository methods. Comments out the calls to the output() method, intended to print to the console the publications mocked to test sync process.
1 parent 52096a4 commit 46131ed

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

tests/Feature/PublicationsRepositoryTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
use Illuminate\Foundation\Testing\RefreshDatabase;
1010
use Tests\Feature\Traits\LoginWithRole;
1111
use Illuminate\Foundation\Testing\WithFaker;
12-
use Tests\Feature\Traits\mockPublicationsRepository;
12+
use Tests\Feature\Traits\MockPublicationsRepository;
1313
use App\Repositories\OrcidPublicationsRepository;
1414
use Tests\Feature\Traits\HasJson;
1515

1616
class PublicationsRepositoryTest extends TestCase
1717
{
18-
use mockPublicationsRepository;
18+
use MockPublicationsRepository;
1919
use RefreshDatabase;
2020
use WithFaker;
2121
use LoginWithRole;
@@ -59,7 +59,7 @@ public function testImportOrcidPublications()
5959
$this->assertCount(5, $this->profile->publications);
6060
$this->assertDatabaseCount('profile_data', 6);
6161

62-
$this->output("PROFILE PUBLICATIONS CREATED", $this->profile->publications, ['profile_id', 'sort_order', 'title']);
62+
// $this->output("PROFILE PUBLICATIONS CREATED", $this->profile->publications, ['profile_id', 'sort_order', 'title']);
6363

6464
$publications_edit_route = route('profiles.edit', [
6565
'profile' => $this->profile,

tests/Feature/Traits/MockPublicationsRepository.php

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,18 @@
55
use App\ProfileData;
66
use App\Repositories\OrcidPublicationsRepository;
77

8-
trait mockPublicationsRepository
8+
trait MockPublicationsRepository
99
{
10-
10+
/**
11+
* Partial mock to return the orcid API response containing publications (ProfileData collection)
12+
*
13+
* @return OrcidPublicationsRepository
14+
*/
1115
public function mockPublicationsRepository()
1216
{
1317
$publications = $this->makePublications();
1418

15-
$this->output("API PUBLICATIONS TO SYNC", $publications, ['profile_id', 'sort_order', 'title']);
19+
// $this->output("API PUBLICATIONS TO SYNC", $publications, ['profile_id', 'sort_order', 'title']);
1620

1721
$pubs_mock = mock(OrcidPublicationsRepository::class)->makePartial();
1822

@@ -23,6 +27,11 @@ public function mockPublicationsRepository()
2327
return $pubs_mock;
2428
}
2529

30+
/**
31+
* Returns a ProfileDataFactory collection of publications exisisting in the DB and new publications
32+
*
33+
* @return \Illuminate\Support\Collection<ProfileDataFactory>
34+
*/
2635
public function makePublications()
2736
{
2837
$orcid_api_new_pubs =

0 commit comments

Comments
 (0)